Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mbedtls update #1939

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Mbedtls update #1939

merged 6 commits into from
Mar 1, 2024

Conversation

disa6302
Copy link
Contributor

Issue #, if available:

What was changed?

  • Update mbedtls version to fix build error with clang
  • Add CI

Why was it changed?

  • With the older mbedtls version, the build on mac failed with the following error:
kvs-sdk/amazon-kinesis-video-streams-webrtc-sdk-c/open-source/libmbedtls/build/src/project_libmbedtls/library/psa_crypto.c:4590:12: error: parameter 'output_size' set but not used [-Werror,-Wunused-but-set-parameter]
    size_t output_size,
           ^
1 error generated.

This error was fixed in 2.28.5.

How was it changed?

  • Changed version in the cmake build file.

What testing was done for the changes?

  • Added a CI job to confirm the build passes
  • Confirm the samples run

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.09%. Comparing base (7e4c503) to head (f74ce12).

❗ Current head f74ce12 differs from pull request most recent head efca161. Consider uploading reports for the commit efca161 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1939      +/-   ##
===========================================
- Coverage    76.12%   76.09%   -0.04%     
===========================================
  Files           48       48              
  Lines        13711    13710       -1     
===========================================
- Hits         10437    10432       -5     
- Misses        3274     3278       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disa6302 disa6302 marked this pull request as ready for review February 29, 2024 23:18
@hassanctech hassanctech self-requested a review March 1, 2024 21:35
Copy link
Contributor

@hassanctech hassanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@niyatim23 niyatim23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@disa6302 disa6302 merged commit dd46d80 into develop Mar 1, 2024
30 checks passed
@disa6302 disa6302 deleted the mbedtls-update branch March 1, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants