Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitter buffer overflows #1677

Merged
merged 8 commits into from
Apr 5, 2023
Merged

Jitter buffer overflows #1677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4230327
Modified jitterbuffer to include checks for timestamp overflow
jdelapla Mar 27, 2023
d8eff57
All tests passing, some new tests still need to be added
jdelapla Mar 29, 2023
7131159
More tests and accompanying fixes
jdelapla Mar 29, 2023
a601400
Resolve coverity finding of multiplication causing type overflow
jdelapla Mar 29, 2023
555e4fd
Change function order
jdelapla Apr 4, 2023
fc84c7a
Clang format
jdelapla Apr 4, 2023
c6bf339
Mac compile errors fixed
jdelapla Apr 4, 2023
98a061e
Commenting out long-running test, adding timestamp overflow test
jdelapla Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ open-source/
outputs
tags
CMakeLists.txt.user
*.swp
7 changes: 6 additions & 1 deletion src/include/com/amazonaws/kinesis/video/webrtcclient/Include.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,12 @@ extern "C" {
/**
* Maximum sequence number in rtp packet/jitter buffer
*/
#define MAX_SEQUENCE_NUM ((UINT32) MAX_UINT16)
#define MAX_RTP_SEQUENCE_NUM ((UINT32) MAX_UINT16)

/**
* Maximum timestamp in rtp packet/jitter buffer
*/
#define MAX_RTP_TIMESTAMP ((UINT32) MAX_UINT32)

/**
* Parameterized string for KVS STUN Server
Expand Down
Loading