-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libwebsockets: update libwebsockets to v4.2-stable #1187
libwebsockets: update libwebsockets to v4.2-stable #1187
Conversation
Signed-off-by: zhiqinli@amazon.com <zhiqinli@amazon.com>
Codecov Report
@@ Coverage Diff @@
## master #1187 +/- ##
===========================================
- Coverage 85.84% 57.54% -28.30%
===========================================
Files 42 42
Lines 10587 10591 +4
===========================================
- Hits 9088 6095 -2993
- Misses 1499 4496 +2997
Continue to review full report at Codecov.
|
@@ -20,7 +20,7 @@ endif() | |||
|
|||
ExternalProject_Add(project_libwebsockets | |||
GIT_REPOSITORY https://github.com/warmcat/libwebsockets.git | |||
GIT_TAG v3.2.3 | |||
GIT_TAG v4.2-stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please change this to the latest release that just went out and we can quickly get this merged:
https://github.com/warmcat/libwebsockets/releases/tag/v4.2.1
@codingspirit
|
@agrexgh , Please run |
@disa6302 |
@disa6302 |
Signed-off-by: zhiqinli@amazon.com zhiqinli@amazon.com
Issue #, if available:
#1147
In libwebsockets v3.2.3, there is a memory access violation issue when use mbedtls with certificates, @ycyang1229 managed to fix this via:
warmcat/libwebsockets#2304
this PR has been merged into libwebsockets main and v4.2-stable branch. Without this patch, using mbedtls with iot certificates will always failed.
Description of changes:
Similar to #1152 , this changes will update libwebsockets to v4.2-stable. This update will fix #1147, and replace old
ws_ping_pong_interval
with newlws_retry_bo_t
to manage ping behaviors, which was introduced since libwebsockets v4.+.ref: https://libwebsockets.org/git/libwebsockets/tree/READMEs/README.lws_retry.md
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.