Adding lock around step state machine to prevent race conditions with

iceAgentStatus
awslabs · Oct 12, 2023 · 2fb6f38 · 2fb6f38
1 parent 96d055e
commit 2fb6f38
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/source/Ice/IceAgentStateMachine.c b/src/source/Ice/IceAgentStateMachine.c
@@ -57,9 +57,12 @@ STATUS stepIceAgentStateMachine(PIceAgent pIceAgent)
     ENTERS();
     STATUS retStatus = STATUS_SUCCESS;
     UINT64 oldState;
+    BOOL locked = FALSE;
 
     CHK(pIceAgent != NULL, STATUS_NULL_ARG);
 
+    MUTEX_LOCK(pIceAgent->lock);
+    locked = TRUE;
     do {
         oldState = pIceAgent->iceAgentState;
 
@@ -87,6 +90,9 @@ STATUS stepIceAgentStateMachine(PIceAgent pIceAgent)
 CleanUp:
 
     CHK_LOG_ERR(retStatus);
+    if (locked) {
+        MUTEX_UNLOCK(pIceAgent->lock);
+    }
 
     LEAVES();
     return retStatus;