Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M1 Build #224

Merged
merged 10 commits into from
Nov 28, 2023
Merged

M1 Build #224

merged 10 commits into from
Nov 28, 2023

Conversation

niyatim23
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2ff9dd7) 75.12% compared to head (df88fc5) 75.11%.

❗ Current head df88fc5 differs from pull request most recent head d87e093. Consider uploading reports for the commit d87e093 to get more accurate results

Files Patch % Lines
src/utils/src/Threadpool.c 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #224      +/-   ##
===========================================
- Coverage    75.12%   75.11%   -0.01%     
===========================================
  Files           52       52              
  Lines        10225    10225              
===========================================
- Hits          7682     7681       -1     
- Misses        2543     2544       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niyatim23 niyatim23 marked this pull request as ready for review November 28, 2023 18:24
Copy link
Contributor

@stefankiesz stefankiesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@niyatim23 niyatim23 merged commit cb69d79 into develop Nov 28, 2023
11 checks passed
@niyatim23 niyatim23 deleted the m1-build branch November 28, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants