Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils - Remove duplicate error code #223

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Utils - Remove duplicate error code #223

merged 1 commit into from
Oct 19, 2023

Conversation

sirknightj
Copy link
Contributor

Description of changes:
Utils Library

Some error codes are duplicated. Adjust the ones starting with LOGGER_ so that they are not duplicate.

#define STATUS_SEMAPHORE_BASE STATUS_UTILS_BASE + 0x01200000
#define STATUS_SEMAPHORE_OPERATION_AFTER_SHUTDOWN STATUS_SEMAPHORE_BASE + 0x00000001

#define STATUS_FILE_LOGGER_BASE STATUS_UTILS_BASE + 0x01200000
#define STATUS_FILE_LOGGER_INDEX_FILE_INVALID_SIZE STATUS_SEMAPHORE_BASE + 0x00000001

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3fdae37) 75.07% compared to head (b93428d) 75.11%.

❗ Current head b93428d differs from pull request most recent head ee19f00. Consider uploading reports for the commit ee19f00 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #223      +/-   ##
===========================================
+ Coverage    75.07%   75.11%   +0.03%     
===========================================
  Files           52       52              
  Lines        10225    10225              
===========================================
+ Hits          7676     7680       +4     
+ Misses        2549     2545       -4     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@disa6302 disa6302 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@sirknightj sirknightj merged commit 2ff9dd7 into develop Oct 19, 2023
@sirknightj sirknightj deleted the utils-error-code branch October 19, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants