Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CNI plugins #500

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Update CNI plugins #500

merged 1 commit into from
Jul 24, 2020

Conversation

mogren
Copy link

@mogren mogren commented Jul 2, 2020

Issue #, if available: #497

Description of changes:

  • Removed CNI_VERSION since the project stopped with releases after v0.7.0 and moved all binaries to the plugins repo
  • Fix name of CNI plugins file
  • Use -n instead of ! -z in bash if-statements

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mogren mogren requested review from abeer91 and heybronson July 2, 2020 05:28
@mogren mogren added the bug Something isn't working label Jul 2, 2020
@mogren
Copy link
Author

mogren commented Jul 15, 2020

Created a test build:

    amazon-ebs: Downloading CNI plugins from Github
    amazon-ebs: --2020-07-15 19:35:05--  https://github.com/containernetworking/plugins/releases/download/v0.8.6/cni-plugins-linux-amd64-v0.8.6.tgz
    amazon-ebs: Resolving github.com (github.com)... 192.30.255.113
    amazon-ebs: Connecting to github.com (github.com)|192.30.255.113|:443... connected.
    amazon-ebs: HTTP request sent, awaiting response... 302 Found
    amazon-ebs: Location: https://github-production-release-asset-2e65be.s3.amazonaws.com/84575398/aa05da80-9564-11ea-8c3e-599dc43b8341?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200715%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200715T193505Z&X-Amz-Expires=300&X-Amz-Signature=a7442518255280b0ba72602747f795a1885faf547def82f36668f9bd4d08f3fc&X-Amz-SignedHeaders=host&actor_id=0&repo_id=84575398&response-content-disposition=attachment%3B%20filename%3Dcni-plugins-linux-amd64-v0.8.6.tgz&response-content-type=application%2Foctet-stream [following]
    amazon-ebs: --2020-07-15 19:35:05--  https://github-production-release-asset-2e65be.s3.amazonaws.com/84575398/aa05da80-9564-11ea-8c3e-599dc43b8341?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200715%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200715T193505Z&X-Amz-Expires=300&X-Amz-Signature=a7442518255280b0ba72602747f795a1885faf547def82f36668f9bd4d08f3fc&X-Amz-SignedHeaders=host&actor_id=0&repo_id=84575398&response-content-disposition=attachment%3B%20filename%3Dcni-plugins-linux-amd64-v0.8.6.tgz&response-content-type=application%2Foctet-stream
    amazon-ebs: Resolving github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)... 52.217.17.180
    amazon-ebs: Connecting to github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)|52.217.17.180|:443... connected.
    amazon-ebs: HTTP request sent, awaiting response... 200 OK
    amazon-ebs: Length: 36878412 (35M) [application/octet-stream]
    amazon-ebs: Saving to: ‘cni-plugins-linux-amd64-v0.8.6.tgz’
    amazon-ebs:
    amazon-ebs: 100%[======================================>] 36,878,412  14.9MB/s   in 2.4s
    amazon-ebs:
    amazon-ebs: 2020-07-15 19:35:08 (14.9 MB/s) - ‘cni-plugins-linux-amd64-v0.8.6.tgz’ saved [36878412/36878412]
    amazon-ebs:
    amazon-ebs: --2020-07-15 19:35:08--  https://github.com/containernetworking/plugins/releases/download/v0.8.6/cni-plugins-linux-amd64-v0.8.6.tgz.sha512
    amazon-ebs: Resolving github.com (github.com)... 192.30.255.113
    amazon-ebs: Connecting to github.com (github.com)|192.30.255.113|:443... connected.
    amazon-ebs: HTTP request sent, awaiting response... 302 Found
    amazon-ebs: Location: https://github-production-release-asset-2e65be.s3.amazonaws.com/84575398/239dc880-9565-11ea-8030-61a71765bc80?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200715%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200715T193508Z&X-Amz-Expires=300&X-Amz-Signature=5373136091c10dfa33f1eba49a8be84a09dbacaf34d2d3f1d076b79f372dd6b3&X-Amz-SignedHeaders=host&actor_id=0&repo_id=84575398&response-content-disposition=attachment%3B%20filename%3Dcni-plugins-linux-amd64-v0.8.6.tgz.sha512&response-content-type=application%2Foctet-stream [following]
    amazon-ebs: --2020-07-15 19:35:08--  https://github-production-release-asset-2e65be.s3.amazonaws.com/84575398/239dc880-9565-11ea-8030-61a71765bc80?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200715%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200715T193508Z&X-Amz-Expires=300&X-Amz-Signature=5373136091c10dfa33f1eba49a8be84a09dbacaf34d2d3f1d076b79f372dd6b3&X-Amz-SignedHeaders=host&actor_id=0&repo_id=84575398&response-content-disposition=attachment%3B%20filename%3Dcni-plugins-linux-amd64-v0.8.6.tgz.sha512&response-content-type=application%2Foctet-stream
    amazon-ebs: Resolving github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)... 52.217.17.180
    amazon-ebs: Connecting to github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)|52.217.17.180|:443... connected.
    amazon-ebs: HTTP request sent, awaiting response... 200 OK
    amazon-ebs: Length: 165 [application/octet-stream]
    amazon-ebs: Saving to: ‘cni-plugins-linux-amd64-v0.8.6.tgz.sha512’
    amazon-ebs:
    amazon-ebs: 100%[======================================>] 165         --.-K/s   in 0s
    amazon-ebs:
    amazon-ebs: 2020-07-15 19:35:09 (2.81 MB/s) - ‘cni-plugins-linux-amd64-v0.8.6.tgz.sha512’ saved [165/165]
    amazon-ebs:
    amazon-ebs: cni-plugins-linux-amd64-v0.8.6.tgz: OK
    amazon-ebs: ./
    amazon-ebs: ./flannel
    amazon-ebs: ./ptp
    amazon-ebs: ./host-local
    amazon-ebs: ./firewall
    amazon-ebs: ./portmap
    amazon-ebs: ./tuning
    amazon-ebs: ./vlan
    amazon-ebs: ./host-device
    amazon-ebs: ./bandwidth
    amazon-ebs: ./sbr
    amazon-ebs: ./static
    amazon-ebs: ./dhcp
    amazon-ebs: ./ipvlan
    amazon-ebs: ./macvlan
    amazon-ebs: ./loopback
    amazon-ebs: ./bridge

@blxdaniel
Copy link
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants