Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Documentation Regarding CNI Custom Network re 1.4.0 release #34

Merged
merged 2 commits into from
Jun 26, 2019

Conversation

taylorb-syd
Copy link

Issue #, if available: N/A

Description of changes: With the soon to be released changed for 1.4.0 of the CNI Plugin the behavior of CNI Custom Networks has changed.

This pull request expands on how customers might use this, and a common use case involving the failure-domain.beta.kubernetes.io/zone label.

Since the PR is dependent on release 1.4.0 of the CNI Plugin, I strongly recommend against merging this until 1.4.0 is released and contingent on the linked PR being included.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nrdlngr nrdlngr merged commit 9c4548c into awsdocs:master Jun 26, 2019
@nrdlngr
Copy link

nrdlngr commented Jun 26, 2019

Thanks so much for your contribution here, @taylorb-syd. The original content has changed since your submission, so I had to do some refactoring. The service team suggested that we stick to just labels instead of offering steps for both labels and annotations (to avoid confusion). I pulled in your procedure for automatically applying an ENIConfig per the node's Availability Zone, however, because that content did not already exist in our docs.

@taylorb-syd taylorb-syd deleted the cnicustomnetwork1.4 branch December 8, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants