-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support for referencing custom configuration in CodeDeploy #848
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #848 +/- ##
===========================================
+ Coverage 94.62% 94.65% +0.02%
===========================================
Files 69 69
Lines 2997 3011 +14
Branches 554 559 +5
===========================================
+ Hits 2836 2850 +14
Misses 85 85
Partials 76 76
Continue to review full report at Codecov.
|
@jlhood There were few tests that are using custom deployments type in deployment preference and expecting the generated cloudformation to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really excited about this change! Thanks so much. I called out one issue that needs to be addressed before we can merge this.
samtranslator/model/preferences/deployment_preference_collection.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating! I think I have a simpler way to do the recursive replacement. Let me know what you think!
samtranslator/model/preferences/deployment_preference_collection.py
Outdated
Show resolved
Hide resolved
tests/translator/input/function_with_custom_conditional_codedeploy_deployment_preference.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with this! Just a few minor cleanups to get tests passing. Also, could you make a small update to the safe deployments documentation page noting that custom deployment configurations are supported?
Thanks so much for iterating on this PR. It's super close. Looking forward to having this feature in SAM!
Issue #, if available:
#836
Description of changes:
Added a list of predefined configurations provided by CodeDeploy. If the user provided configuration is one of the predefined configurations then the generate Cloudformation will have
"CodeDeployDefault.Lambda
as a prefix, but if it's a custom CodeDeploy Configuration then the Prefix will not be addedDescription of how you validated changes:
Added relevant unit tests and the end to end tests.
Checklist:
make pr
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.