Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: encrypt SNS and Kinesis resources in integration test templates #3578

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

gracelu0
Copy link
Contributor

@gracelu0 gracelu0 commented Apr 9, 2024

Issue #, if available

N/A

Description of changes

Enable encryption using KmsMasterKeyId for SNS topic and StreamEncryption for Kinesis stream resources in integration test templates to follow best security practices.

Description of how you validated changes

Ran updated integration tests successfully.

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gracelu0 gracelu0 requested a review from a team as a code owner April 9, 2024 00:35
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested that these integration tests are still deployable after the change?

@gracelu0
Copy link
Contributor Author

gracelu0 commented Apr 9, 2024

Have you tested that these integration tests are still deployable after the change?

I ran the updated integration tests locally and they pass, so they do deploy successfully still after the change.

@gracelu0 gracelu0 merged commit cb68b92 into aws:develop Apr 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants