chore: add support for pydantic 2.x #3282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second commit introduces a |
ssenchenko
reviewed
Aug 2, 2023
hoffa
reviewed
Aug 4, 2023
Co-authored-by: Christoffer Rehn <1280602+hoffa@users.noreply.github.com>
ConnorRobertson
approved these changes
Aug 9, 2023
ssenchenko
approved these changes
Aug 9, 2023
|
Thank you for reviewing. I noticed this commit is not included in 1.73.0. Is it forgotten? |
|
Hi @yan12125 this PR was merged yesterday, it needs to go through our release process which can take some time. Should be released within the coming week or 2. |
|
Got it, thanks! |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 18, 2023
We already fixed all deprecation warnings for Pydantic 2 and we can thus remove Pydantic 2 limitation. Even if we are waiting for other dependencies (aws-sam-translator) it should be save to remove the limit - we will get Pydantic 2 when aws-sam-translate new version is released in a week or two (Pydantic 2 support has been added last week in aws/serverless-application-model#3282)
jedcunningham
pushed a commit
to apache/airflow
that referenced
this pull request
Aug 18, 2023
We already fixed all deprecation warnings for Pydantic 2 and we can thus remove Pydantic 2 limitation. Even if we are waiting for other dependencies (aws-sam-translator) it should be save to remove the limit - we will get Pydantic 2 when aws-sam-translate new version is released in a week or two (Pydantic 2 support has been added last week in aws/serverless-application-model#3282)
potiuk
added a commit
to apache/airflow
that referenced
this pull request
Aug 25, 2023
We already fixed all deprecation warnings for Pydantic 2 and we can thus remove Pydantic 2 limitation. Even if we are waiting for other dependencies (aws-sam-translator) it should be save to remove the limit - we will get Pydantic 2 when aws-sam-translate new version is released in a week or two (Pydantic 2 support has been added last week in aws/serverless-application-model#3282) (cherry picked from commit 754a4ab)
|
Not released in v1.74.0 either. Anyone knows why? |
|
this was part of v1.75.0, sorry about the delay! |
ahidalgob
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 15, 2024
We already fixed all deprecation warnings for Pydantic 2 and we can thus remove Pydantic 2 limitation. Even if we are waiting for other dependencies (aws-sam-translator) it should be save to remove the limit - we will get Pydantic 2 when aws-sam-translate new version is released in a week or two (Pydantic 2 support has been added last week in aws/serverless-application-model#3282) (cherry picked from commit 754a4ab396e6e6002f79a716f93ed71712393687) GitOrigin-RevId: 100f37d9a4cd18626effe491fab56957252e7b1d
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 18, 2024
We already fixed all deprecation warnings for Pydantic 2 and we can thus remove Pydantic 2 limitation. Even if we are waiting for other dependencies (aws-sam-translator) it should be save to remove the limit - we will get Pydantic 2 when aws-sam-translate new version is released in a week or two (Pydantic 2 support has been added last week in aws/serverless-application-model#3282) GitOrigin-RevId: 754a4ab396e6e6002f79a716f93ed71712393687
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 19, 2024
We already fixed all deprecation warnings for Pydantic 2 and we can thus remove Pydantic 2 limitation. Even if we are waiting for other dependencies (aws-sam-translator) it should be save to remove the limit - we will get Pydantic 2 when aws-sam-translate new version is released in a week or two (Pydantic 2 support has been added last week in aws/serverless-application-model#3282) GitOrigin-RevId: 754a4ab396e6e6002f79a716f93ed71712393687
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 8, 2024
We already fixed all deprecation warnings for Pydantic 2 and we can thus remove Pydantic 2 limitation. Even if we are waiting for other dependencies (aws-sam-translator) it should be save to remove the limit - we will get Pydantic 2 when aws-sam-translate new version is released in a week or two (Pydantic 2 support has been added last week in aws/serverless-application-model#3282) GitOrigin-RevId: 754a4ab396e6e6002f79a716f93ed71712393687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
This PR supersedes #3249
Description of changes
This change brings pydantic 2.x support without breaking 1.x support by utilizing the compatibility package pydantic.v1
Description of how you validated changes
Run the test suite with both pydantic 1.10.9 and 2.0.2, and both are green
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.