Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert requestparams #1157

Conversation

ShreyaGangishetty
Copy link

@ShreyaGangishetty ShreyaGangishetty commented Sep 24, 2019

Issue #, if available:
#953

Description of changes:
Reverting #953 from v1.15.0 release

Description of how you validated changes:
reverted the commit for #953 PR
manually resolved few merge conflicts

Checklist:

  • make pr passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Sep 24, 2019

Codecov Report

Merging #1157 into release/v1.15.0 will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.15.0    #1157      +/-   ##
===================================================
- Coverage            94.36%   94.29%   -0.07%     
===================================================
  Files                   71       71              
  Lines                 3621     3577      -44     
  Branches               713      701      -12     
===================================================
- Hits                  3417     3373      -44     
  Misses                 104      104              
  Partials               100      100
Impacted Files Coverage Δ
samtranslator/model/eventsources/push.py 88.88% <ø> (-0.61%) ⬇️
samtranslator/swagger/swagger.py 91.85% <ø> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81aa57...1af3207. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants