-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add additional properties for Cloudwatch Schedule - Enabled, Name, Description #1006
feat: Add additional properties for Cloudwatch Schedule - Enabled, Name, Description #1006
Conversation
Wondering if someone can help me figure out why the travis-ci build is failing. It seems like the 7 tests that are failing have been failing from the time I forked the repo. |
c4b55b4
to
465ba2a
Compare
From the error message:
I guess it's related to a cfn-lint issue: aws-cloudformation/cfn-lint#1002. |
@yan12125 that looked to be exactly the case. After triggering a rebuild on travis-ci after cfn-lint 22.2 released all the tests are passing! Thanks for the heads up on that issue. 👍 |
Thanks for the contribution! Could you add a test for this? |
Codecov Report
@@ Coverage Diff @@
## develop #1006 +/- ##
==========================================
+ Coverage 94.71% 94.82% +0.1%
==========================================
Files 69 69
Lines 3160 3244 +84
Branches 606 632 +26
==========================================
+ Hits 2993 3076 +83
- Misses 85 87 +2
+ Partials 82 81 -1
Continue to review full report at Codecov.
|
Added an additional test for the schedule properties. Let me know if there is anything else I can do/fix for this! |
"Enabled: True" Why capital "T", when other event types are "Enabled: true"? |
Issue #, if available:
#934
Description of changes:
Added the ability to set the name, description, and enable state of Cloudwatch Schedules.
Example usage of new properties:
Description of how you validated changes:
Validated changes through testing transforms as described in the contributing guidelines
and by verifying with an appended test case.
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.