update conditions in tests to fix lint failures (#3705)

aws · Jan 9, 2025 · a8c0a70 · a8c0a70
1 parent 17000c1
commit a8c0a70
Show file tree

Hide file tree

Showing 20 changed files with 70 additions and 40 deletions.
diff --git a/tests/translator/input/basic_application.yaml b/tests/translator/input/basic_application.yaml
@@ -1,8 +1,8 @@
 Conditions:
   TestCondition:
     Fn::Equals:
-    - true
-    - false
+    - !Ref AWS::AccountId
+    - myAccountId
 Resources:
   BasicApplication:
     Type: AWS::Serverless::Application

diff --git a/tests/translator/input/definition_body_intrinsics_support.yaml b/tests/translator/input/definition_body_intrinsics_support.yaml
@@ -13,8 +13,8 @@ Description: >
 Conditions:
   FalseCondition:
     Fn::Equals:
-    - true
-    - false
+    - !Ref AWS::AccountId
+    - myAccountId
 
 Resources:
   # Rest Api with DefinitionBody under If intrinsic, SwaggerEditor not used

diff --git a/tests/translator/input/function_with_deployment_preference_alarms_intrinsic_if.yaml b/tests/translator/input/function_with_deployment_preference_alarms_intrinsic_if.yaml
@@ -1,8 +1,8 @@
 Conditions:
   MyCondition:
     Fn::Equals:
-    - true
-    - false
+    - !Ref AWS::AccountId
+    - myAccountId
 Resources:
   MinimalFunction:
     Type: AWS::Serverless::Function

diff --git a/tests/translator/input/s3_with_condition.yaml b/tests/translator/input/s3_with_condition.yaml
@@ -1,8 +1,8 @@
 Conditions:
   MyCondition:
     Fn::Equals:
-    - true
-    - false
+    - !Ref AWS::AccountId
+    - myAccountId
 Resources:
   ThumbnailFunction:
     Type: AWS::Serverless::Function

diff --git a/tests/translator/input/sns_intrinsics.yaml b/tests/translator/input/sns_intrinsics.yaml
@@ -6,8 +6,8 @@ Parameters:
 Conditions:
   MyCondition:
     Fn::Equals:
-    - true
-    - false
+    - !Ref AWS::AccountId
+    - myAccountId
 
 Resources:
   SaveNotificationFunction:

diff --git a/tests/translator/output/aws-cn/basic_application.json b/tests/translator/output/aws-cn/basic_application.json
@@ -2,8 +2,10 @@
   "Conditions": {
     "TestCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/tests/translator/output/aws-cn/definition_body_intrinsics_support.json b/tests/translator/output/aws-cn/definition_body_intrinsics_support.json
@@ -3,8 +3,10 @@
   "Conditions": {
     "FalseCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/tests/translator/output/aws-cn/function_with_deployment_preference_alarms_intrinsic_if.json b/tests/translator/output/aws-cn/function_with_deployment_preference_alarms_intrinsic_if.json
@@ -2,8 +2,10 @@
   "Conditions": {
     "MyCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/tests/translator/output/aws-cn/s3_with_condition.json b/tests/translator/output/aws-cn/s3_with_condition.json
@@ -2,8 +2,10 @@
   "Conditions": {
     "MyCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/tests/translator/output/aws-cn/sns_intrinsics.json b/tests/translator/output/aws-cn/sns_intrinsics.json
@@ -2,8 +2,10 @@
   "Conditions": {
     "MyCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/tests/translator/output/aws-us-gov/basic_application.json b/tests/translator/output/aws-us-gov/basic_application.json
@@ -2,8 +2,10 @@
   "Conditions": {
     "TestCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/tests/translator/output/aws-us-gov/definition_body_intrinsics_support.json b/tests/translator/output/aws-us-gov/definition_body_intrinsics_support.json
@@ -3,8 +3,10 @@
   "Conditions": {
     "FalseCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/...translator/output/aws-us-gov/function_with_deployment_preference_alarms_intrinsic_if.json b/...translator/output/aws-us-gov/function_with_deployment_preference_alarms_intrinsic_if.json
@@ -2,8 +2,10 @@
   "Conditions": {
     "MyCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/tests/translator/output/aws-us-gov/s3_with_condition.json b/tests/translator/output/aws-us-gov/s3_with_condition.json
@@ -2,8 +2,10 @@
   "Conditions": {
     "MyCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/tests/translator/output/aws-us-gov/sns_intrinsics.json b/tests/translator/output/aws-us-gov/sns_intrinsics.json
@@ -2,8 +2,10 @@
   "Conditions": {
     "MyCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/tests/translator/output/basic_application.json b/tests/translator/output/basic_application.json
@@ -2,8 +2,10 @@
   "Conditions": {
     "TestCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/tests/translator/output/definition_body_intrinsics_support.json b/tests/translator/output/definition_body_intrinsics_support.json
@@ -3,8 +3,10 @@
   "Conditions": {
     "FalseCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/tests/translator/output/function_with_deployment_preference_alarms_intrinsic_if.json b/tests/translator/output/function_with_deployment_preference_alarms_intrinsic_if.json
@@ -2,8 +2,10 @@
   "Conditions": {
     "MyCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/tests/translator/output/s3_with_condition.json b/tests/translator/output/s3_with_condition.json
@@ -2,8 +2,10 @@
   "Conditions": {
     "MyCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },

diff --git a/tests/translator/output/sns_intrinsics.json b/tests/translator/output/sns_intrinsics.json
@@ -2,8 +2,10 @@
   "Conditions": {
     "MyCondition": {
       "Fn::Equals": [
-        true,
-        false
+        {
+          "Ref": "AWS::AccountId"
+        },
+        "myAccountId"
       ]
     }
   },