-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: forbid extras in Configs #5042
base: master
Are you sure you want to change the base?
Conversation
0e85b45
to
6223f26
Compare
@@ -831,6 +834,10 @@ def _prepare_train_script( | |||
+ "Only .py and .sh scripts are supported." | |||
) | |||
execute_driver = EXECUTE_BASIC_SCRIPT_DRIVER | |||
else: | |||
raise ValueError( | |||
f"Invalid configuration, please provide a valid SourceCode: {source_code}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like from if else ladder above, "please provide a valid SourceCode or distributed or base_command?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, thats true let me make this clearer to prevent confusion
Issue #, if available:
Addresses: #5041
Description of changes:
UnboundLocalError
is raised if an invalidSourceCode
object is passed into ModelTrainerTesting done:
SourceCode
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.