Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forbid extras in Configs #5042

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

benieric
Copy link
Contributor

@benieric benieric commented Feb 14, 2025

Issue #, if available:
Addresses: #5041

Description of changes:

  • Fix bug where a cryptic UnboundLocalError is raised if an invalid SourceCode object is passed into ModelTrainer
  • Details in issue
  • Additionally addresses a small bug where destructor fails if called before class is fully initialized
AttributeError: 'ModelTrainer' object has no attribute '__pydantic_private__'

Testing done:

  • Added unit test to make sure user cannot create an invalid SourceCode

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@benieric benieric requested a review from a team as a code owner February 14, 2025 07:37
@@ -831,6 +834,10 @@ def _prepare_train_script(
+ "Only .py and .sh scripts are supported."
)
execute_driver = EXECUTE_BASIC_SCRIPT_DRIVER
else:
raise ValueError(
f"Invalid configuration, please provide a valid SourceCode: {source_code}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like from if else ladder above, "please provide a valid SourceCode or distributed or base_command?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thats true let me make this clearer to prevent confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants