feat: Make DistributedConfig Extensible #5039
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
DistributedConfig
class to be more extensibleBase Class Update:
Customer Usage Example:
How to create a
custom_driver.py
:What changes in the container?
In order to prevent conflicts with user provided code in the
driver_dir
and sdk scripts, the directory structure inside the container will change to be like below.Before:
After:
What env vars are being added?
os.environ["SM_ENTRY_SCRIPT"]
- points to entry scriptos.environ["SM_DISTRIBUTED_CONFIG"]
- points to a json dump of the DistributedConfig classos.environ["SM_SOURCE_DIR"]
- points to the "/opt/ml/input/data/code"os.environ["SM_DRIVER_DIR"]
- points to "/opt/ml/input/data/sm_drivers/drivers"Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.