RolesAnywhere-3788: Include token TTL header in token API response #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlalcorn
requested changes
Dec 28, 2022
d717747 to
5ae07a1
Compare
rlalcorn
reviewed
Dec 28, 2022
aws_signing_helper/serve.go
Outdated
| @@ -228,6 +270,9 @@ func Serve(port int, credentialsOptions CredentialsOpts) { | |||
| refreshableCred.SecretAccessKey = credentialProcessOutput.SecretAccessKey | |||
| refreshableCred.Token = credentialProcessOutput.SessionToken | |||
| refreshableCred.Expiration, _ = time.Parse(time.RFC3339, credentialProcessOutput.Expiration) | |||
| refreshableCred.Code = "Success" | |||
There was a problem hiding this comment.
Extract "Success" and "AWS-HMAC" to constants, maybe?
There was a problem hiding this comment.
I've changed this and added another commit to this PR.
rlalcorn
approved these changes
Dec 29, 2022
b3b039c to
67cfd99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Include token TTL header in the response to the token API when serving a local endpoint.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.