Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix website version dropdown #7831

Merged
merged 1 commit into from
Mar 4, 2025
Merged

docs: Fix website version dropdown #7831

merged 1 commit into from
Mar 4, 2025

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Mar 4, 2025 •
edited
Loading

Fixes #N/A

Description

Version dropdown ordering was reversed and was causing latest to be marked as v0.32

How was this change tested?

prepareWebsite

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner March 4, 2025 03:28
@netlify Netlify
Copy link

netlify bot commented Mar 4, 2025 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 9aad3df
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67c67547a06f3c0008dab854

@coveralls
Copy link

coveralls commented Mar 4, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13645700769

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 67.141%
Totals Coverage Status
Change from base Build 13645531349: 0.01%
Covered Lines: 6747
Relevant Lines: 10049
💛 - Coveralls

@jonathan-innis jonathan-innis enabled auto-merge (squash) March 4, 2025 03:37
@jonathan-innis jonathan-innis merged commit 4e35023 into aws:main Mar 4, 2025
17 checks passed
@jonathan-innis jonathan-innis deleted the fix-version-dropdown branch March 4, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

@saurav-agarwalla saurav-agarwalla Awaiting requested review from saurav-agarwalla saurav-agarwalla is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @engedaam