Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix E2E test flakes #7827

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Fix E2E test flakes after EC2NodeClass permission validation changes

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner March 3, 2025 21:28
@jonathan-innis jonathan-innis requested a review from engedaam March 3, 2025 21:28
Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 576759c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67c629cbb80334000856ff65

@coveralls
Copy link

coveralls commented Mar 3, 2025

Pull Request Test Coverage Report for Build 13641503102

Details

  • 11 of 14 (78.57%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 67.131%

Changes Missing Coverage Covered Lines Changed/Added Lines %
test/pkg/debug/pod.go 0 1 0.0%
test/pkg/environment/common/expectations.go 0 2 0.0%
Totals Coverage Status
Change from base Build 13639087627: 0.01%
Covered Lines: 6746
Relevant Lines: 10049

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the fix-e2e-test-flakes branch 2 times, most recently from 79fa4aa to 5c57a37 Compare March 3, 2025 21:47
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-576759c710781464cf0168bfe2422c3fd720685f.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-576759c710781464cf0168bfe2422c3fd720685f" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jonathan-innis jonathan-innis enabled auto-merge (squash) March 3, 2025 23:33
Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 51e7f86 into aws:main Mar 3, 2025
32 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants