Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add CreateError when launch template isn't found #7711

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Add CreateError when launch template isn't found so that we ensure that all failures that occur from launchInstance return error reasons

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner February 8, 2025 01:57
@jonathan-innis jonathan-innis requested a review from jmdeal February 8, 2025 01:57
Copy link

netlify bot commented Feb 8, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 5e311d5
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67a6ba149f25450008c67022

Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link

netlify bot commented Feb 8, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 84f22b0
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67a6ba1b7ec2fe0008679c56

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

github-actions bot commented Feb 8, 2025

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-84f22b05d7616d37f47d909c0b79e57f015cda1a.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-84f22b05d7616d37f47d909c0b79e57f015cda1a" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13211168798

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.766%

Totals Coverage Status
Change from base Build 13209852205: 0.0%
Covered Lines: 5803
Relevant Lines: 8960

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 2cb43bc into aws:main Feb 8, 2025
33 of 34 checks passed
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants