Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add Support for Upstream E2E tests with default AWS Provider EC2NodeClass #7697

Merged
merged 1 commit into from
Feb 20, 2025
Merged

test: Add Support for Upstream E2E tests with default AWS Provider EC2NodeClass #7697

merged 1 commit into from
Feb 20, 2025

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Feb 5, 2025

Fixes #N/A

Description

How was this change tested?

  • Manually tested

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner February 5, 2025 16:41
@engedaam engedaam marked this pull request as draft February 5, 2025 16:41
@netlify Netlify
Copy link

netlify bot commented Feb 5, 2025 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 84bff6d
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67b795e7cfae62000805e936

@coveralls
Copy link

coveralls commented Feb 5, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13444438787

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.215%
Totals Coverage Status
Change from base Build 13381487008: 0.0%
Covered Lines: 5977
Relevant Lines: 9165
💛 - Coveralls

@engedaam engedaam marked this pull request as ready for review February 14, 2025 17:50
@engedaam engedaam force-pushed the adding-support-for-ustream-e2etests branch from 8b81f12 to 901a250 Compare February 14, 2025 18:52
@engedaam engedaam force-pushed the adding-support-for-ustream-e2etests branch 2 times, most recently from 7abb501 to 63349ad Compare February 14, 2025 23:11
@engedaam engedaam force-pushed the adding-support-for-ustream-e2etests branch from bc84b17 to 84bff6d Compare February 20, 2025 20:51
jmdeal
jmdeal approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit bb2efce into aws:main Feb 20, 2025
18 checks passed
@engedaam engedaam deleted the adding-support-for-ustream-e2etests branch February 20, 2025 22:01
brian-villa pushed a commit to brian-villa/karpenter-provider-aws that referenced this pull request Feb 24, 2025
@engedaam @brian-villa
test: Add Support for Upstream E2E tests with default AWS Provider EC…
5a69a24 
…2NodeClass (aws#7697)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@saurav-agarwalla saurav-agarwalla Awaiting requested review from saurav-agarwalla saurav-agarwalla is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jmdeal