Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace golang.org/x/exp/slices with slices #7686

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

Juneezee
Copy link
Contributor

@Juneezee Juneezee commented Feb 2, 2025

Fixes #N/A

Description

The experimental functions in golang.org/x/exp/slices are now available in the standard library in Go 1.21.

Reference: https://go.dev/doc/go1.21#slices

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The experimental functions in `golang.org/x/exp/slices` are now
available in the standard library in Go 1.21.

Reference: https://go.dev/doc/go1.21#slices
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@Juneezee Juneezee requested a review from a team as a code owner February 2, 2025 15:40
@Juneezee Juneezee requested a review from jigisha620 February 2, 2025 15:40
Copy link

netlify bot commented Feb 2, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 13da849
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/679f9205c12f29000862e08a

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) February 3, 2025 21:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13100221027

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.858%

Totals Coverage Status
Change from base Build 13083813691: 0.0%
Covered Lines: 5797
Relevant Lines: 8938

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 48e5ad5 into aws:main Feb 3, 2025
18 checks passed
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Feb 19, 2025
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants