Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make AMISelectorTerm.Owner string #7646

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

juliusmh
Copy link
Contributor

No description provided.

@juliusmh juliusmh requested a review from a team as a code owner January 27, 2025 11:26
@juliusmh juliusmh requested a review from rschalo January 27, 2025 11:26
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit e0e3dab
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67a5a61fbee7e000088a4241
😎 Deploy Preview https://deploy-preview-7646--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jmdeal jmdeal self-assigned this Jan 27, 2025
@juliusmh
Copy link
Contributor Author

@jmdeal @rschalo anything missing here?

@jmdeal
Copy link
Contributor

jmdeal commented Jan 31, 2025

Sorry for the delay, it looks good but we've since release v1.2 which has added a new docs section for that release and removed the section for v0.37. If you're able to make those updates, this will be good to go.

@jonathan-innis jonathan-innis force-pushed the docs_ami_selector_owner_string branch from 3ed97a7 to e0e3dab Compare February 7, 2025 06:20
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) February 7, 2025 06:20
@jonathan-innis jonathan-innis merged commit 52df823 into aws:main Feb 7, 2025
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13194390151

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 64.926%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.81%
Totals Coverage Status
Change from base Build 13191304092: -0.02%
Covered Lines: 5805
Relevant Lines: 8941

💛 - Coveralls

edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants