Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Helm: Add sidecarVolumeMounts and extraVolumeMounts volumes to all sidecars #7608

Merged

Conversation

oleksiytsyban
Copy link
Contributor

Description
It is possible to add more than one sidecar container to Values.controller.sidecarContainer section, but volumes from sidecarVolumeMounts and sidecarVolumeMounts are added only to the last sidecar container. This change is to ensure that each sidecar container receives the appropriate volume mounts.

How was this change tested?
Helm chart tested locally.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@oleksiytsyban oleksiytsyban requested a review from a team as a code owner January 18, 2025 04:36
Copy link

netlify bot commented Jan 18, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 004b39b
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67a5a8dc66eb230008aafacb

@jmdeal jmdeal self-assigned this Jan 27, 2025
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@jonathan-innis
Copy link
Contributor

Makes sense to me!

@jonathan-innis jonathan-innis enabled auto-merge (squash) February 7, 2025 06:32
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-51020f0c12b936699a16039bbf63b3964451d7c2.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-51020f0c12b936699a16039bbf63b3964451d7c2" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13194533856

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 64.926%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.81%
Totals Coverage Status
Change from base Build 13191304092: -0.02%
Covered Lines: 5805
Relevant Lines: 8941

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 84da3db into aws:main Feb 7, 2025
17 checks passed
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Feb 19, 2025
… all sidecars (aws#7608)

Co-authored-by: Oleksiy Tsyban <oleksiy.tsyban@ringcentral.com>
Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
@oleksiytsyban oleksiytsyban deleted the multiple-sidecars-volume-mounts branch March 3, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants