-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Helm: Add sidecarVolumeMounts and extraVolumeMounts volumes to all sidecars #7608
chore: Helm: Add sidecarVolumeMounts and extraVolumeMounts volumes to all sidecars #7608
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Makes sense to me! |
Snapshot successfully published to
|
Pull Request Test Coverage Report for Build 13194533856Details
💛 - Coveralls |
… all sidecars (aws#7608) Co-authored-by: Oleksiy Tsyban <oleksiy.tsyban@ringcentral.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
Description
It is possible to add more than one sidecar container to Values.controller.sidecarContainer section, but volumes from sidecarVolumeMounts and sidecarVolumeMounts are added only to the last sidecar container. This change is to ensure that each sidecar container receives the appropriate volume mounts.
How was this change tested?
Helm chart tested locally.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.