Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: smoke test for webhook e2e #7218

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Oct 14, 2024

Fixes #N/A

Description
Enables smoke test for webhooks for E2E testing. This coerces the action from a string to bool

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Oct 14, 2024

Pull Request Test Coverage Report for Build 11350797827

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.692%

Totals Coverage Status
Change from base Build 11278719400: 0.0%
Covered Lines: 5894
Relevant Lines: 7490

💛 - Coveralls

@rschalo rschalo marked this pull request as ready for review October 14, 2024 22:06
@rschalo rschalo requested a review from a team as a code owner October 14, 2024 22:06
@rschalo rschalo requested a review from engedaam October 14, 2024 22:06
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit a80736f into aws:release-v0.37.x Oct 15, 2024
14 checks passed
@rschalo rschalo deleted the webhook-e2e-fix branch October 15, 2024 17:08
rschalo added a commit to rschalo/karpenter-provider-aws that referenced this pull request Oct 15, 2024
rschalo added a commit to rschalo/karpenter-provider-aws that referenced this pull request Oct 15, 2024
rschalo added a commit to rschalo/karpenter-provider-aws that referenced this pull request Oct 15, 2024
rschalo added a commit to rschalo/karpenter-provider-aws that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants