-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
11 changed files
with
226 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
169 changes: 169 additions & 0 deletions
169
pkg/controllers/nodeclaim/capacityreservation/suite_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,169 @@ | ||
| /* | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package capacityreservation_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "testing" | ||
|
|
||
| "github.com/aws/aws-sdk-go-v2/service/ec2" | ||
| ec2types "github.com/aws/aws-sdk-go-v2/service/ec2/types" | ||
| "github.com/samber/lo" | ||
| corev1 "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/client-go/tools/record" | ||
| karpv1 "sigs.k8s.io/karpenter/pkg/apis/v1" | ||
| corecloudprovider "sigs.k8s.io/karpenter/pkg/cloudprovider" | ||
| "sigs.k8s.io/karpenter/pkg/events" | ||
| coretest "sigs.k8s.io/karpenter/pkg/test" | ||
|
|
||
| "github.com/aws/karpenter-provider-aws/pkg/apis" | ||
| "github.com/aws/karpenter-provider-aws/pkg/cloudprovider" | ||
| "github.com/aws/karpenter-provider-aws/pkg/controllers/nodeclaim/capacityreservation" | ||
| "github.com/aws/karpenter-provider-aws/pkg/fake" | ||
| "github.com/aws/karpenter-provider-aws/pkg/operator/options" | ||
| "github.com/aws/karpenter-provider-aws/pkg/test" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| . "sigs.k8s.io/karpenter/pkg/test/expectations" | ||
| "sigs.k8s.io/karpenter/pkg/test/v1alpha1" | ||
| . "sigs.k8s.io/karpenter/pkg/utils/testing" | ||
| ) | ||
|
|
||
| var ctx context.Context | ||
| var stop context.CancelFunc | ||
| var env *coretest.Environment | ||
| var awsEnv *test.Environment | ||
| var controller *capacityreservation.Controller | ||
|
|
||
| func TestAWS(t *testing.T) { | ||
| ctx = TestContextWithLogger(t) | ||
| RegisterFailHandler(Fail) | ||
| RunSpecs(t, "SSM Invalidation Controller") | ||
| } | ||
|
|
||
| var _ = BeforeSuite(func() { | ||
| env = coretest.NewEnvironment(coretest.WithCRDs(apis.CRDs...), coretest.WithCRDs(v1alpha1.CRDs...), coretest.WithFieldIndexers(coretest.NodeProviderIDFieldIndexer(ctx))) | ||
| ctx = options.ToContext(ctx, test.Options()) | ||
| ctx, stop = context.WithCancel(ctx) | ||
| awsEnv = test.NewEnvironment(ctx, env) | ||
|
|
||
| cloudProvider := cloudprovider.New(awsEnv.InstanceTypesProvider, awsEnv.InstanceProvider, events.NewRecorder(&record.FakeRecorder{}), | ||
| env.Client, awsEnv.AMIProvider, awsEnv.SecurityGroupProvider, awsEnv.CapacityReservationProvider) | ||
| controller = capacityreservation.NewController(env.Client, cloudProvider) | ||
| }) | ||
|
|
||
| var _ = AfterSuite(func() { | ||
| stop() | ||
| Expect(env.Stop()).To(Succeed(), "Failed to stop environment") | ||
| }) | ||
|
|
||
| var _ = Describe("Capacity Reservation NodeClaim Controller", func() { | ||
| var nodeClaim *karpv1.NodeClaim | ||
| var node *corev1.Node | ||
| var reservationID string | ||
| BeforeEach(func() { | ||
| reservationID = "cr-foo" | ||
| instance := ec2types.Instance{ | ||
| ImageId: lo.ToPtr(fake.ImageID()), | ||
| InstanceType: ec2types.InstanceType("m5.large"), | ||
| SubnetId: lo.ToPtr(fake.SubnetID()), | ||
| SpotInstanceRequestId: nil, | ||
| State: &ec2types.InstanceState{ | ||
| Name: ec2types.InstanceStateNameRunning, | ||
| }, | ||
| InstanceId: lo.ToPtr(fake.InstanceID()), | ||
| CapacityReservationId: &reservationID, | ||
| Placement: &ec2types.Placement{ | ||
| AvailabilityZone: lo.ToPtr("test-zone-1a"), | ||
| }, | ||
| SecurityGroups: []ec2types.GroupIdentifier{{GroupId: lo.ToPtr(fake.SecurityGroupID())}}, | ||
| } | ||
| awsEnv.EC2API.DescribeInstancesBehavior.Output.Set(&ec2.DescribeInstancesOutput{ | ||
| Reservations: []ec2types.Reservation{{Instances: []ec2types.Instance{instance}}}, | ||
| }) | ||
|
|
||
| nodeClaim = coretest.NodeClaim(karpv1.NodeClaim{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Labels: map[string]string{ | ||
| karpv1.CapacityTypeLabelKey: karpv1.CapacityTypeReserved, | ||
| corecloudprovider.ReservationIDLabel: reservationID, | ||
| karpv1.NodeRegisteredLabelKey: "true", | ||
| }, | ||
| }, | ||
| Status: karpv1.NodeClaimStatus{ | ||
| ProviderID: fmt.Sprintf("aws:///test-zone-1a/%s", *instance.InstanceId), | ||
| }, | ||
| }) | ||
| node = coretest.NodeClaimLinkedNode(nodeClaim) | ||
| }) | ||
| It("should demote nodeclaims and nodes from reserved to on-demand", func() { | ||
| ExpectApplied(ctx, env.Client, nodeClaim, node) | ||
| ExpectSingletonReconciled(ctx, controller) | ||
|
|
||
| // Since the backing instance is still under a capacity reservation, we shouldn't demote the nodeclaim or node | ||
| nodeClaim = ExpectExists(ctx, env.Client, nodeClaim) | ||
| Expect(nodeClaim.Labels).To(HaveKeyWithValue(karpv1.CapacityTypeLabelKey, karpv1.CapacityTypeReserved)) | ||
| Expect(nodeClaim.Labels).To(HaveKeyWithValue(corecloudprovider.ReservationIDLabel, reservationID)) | ||
| node = ExpectExists(ctx, env.Client, node) | ||
| Expect(node.Labels).To(HaveKeyWithValue(karpv1.CapacityTypeLabelKey, karpv1.CapacityTypeReserved)) | ||
| Expect(node.Labels).To(HaveKeyWithValue(corecloudprovider.ReservationIDLabel, reservationID)) | ||
|
|
||
| out := awsEnv.EC2API.DescribeInstancesBehavior.Output.Clone() | ||
| out.Reservations[0].Instances[0].CapacityReservationId = nil | ||
| awsEnv.EC2API.DescribeInstancesBehavior.Output.Set(out) | ||
|
|
||
| // Now that the backing instance is no longer part of a capacity reservation, we should demote the resources by | ||
| // updating the capacity type to on-demand and removing the reservation ID label. | ||
| ExpectSingletonReconciled(ctx, controller) | ||
| nodeClaim = ExpectExists(ctx, env.Client, nodeClaim) | ||
| Expect(nodeClaim.Labels).To(HaveKeyWithValue(karpv1.CapacityTypeLabelKey, karpv1.CapacityTypeOnDemand)) | ||
| Expect(nodeClaim.Labels).ToNot(HaveKey(corecloudprovider.ReservationIDLabel)) | ||
| node = ExpectExists(ctx, env.Client, node) | ||
| Expect(node.Labels).To(HaveKeyWithValue(karpv1.CapacityTypeLabelKey, karpv1.CapacityTypeOnDemand)) | ||
| Expect(node.Labels).ToNot(HaveKey(corecloudprovider.ReservationIDLabel)) | ||
| }) | ||
| It("should demote nodes from reserved to on-demand even if their nodeclaim was demoted previously", func() { | ||
| out := awsEnv.EC2API.DescribeInstancesBehavior.Output.Clone() | ||
| out.Reservations[0].Instances[0].CapacityReservationId = nil | ||
| awsEnv.EC2API.DescribeInstancesBehavior.Output.Set(out) | ||
|
|
||
| ExpectApplied(ctx, env.Client, nodeClaim) | ||
| ExpectSingletonReconciled(ctx, controller) | ||
| nodeClaim = ExpectExists(ctx, env.Client, nodeClaim) | ||
| Expect(nodeClaim.Labels).To(HaveKeyWithValue(karpv1.CapacityTypeLabelKey, karpv1.CapacityTypeOnDemand)) | ||
| Expect(nodeClaim.Labels).ToNot(HaveKey(corecloudprovider.ReservationIDLabel)) | ||
|
|
||
| ExpectApplied(ctx, env.Client, node) | ||
| ExpectSingletonReconciled(ctx, controller) | ||
| node = ExpectExists(ctx, env.Client, node) | ||
| Expect(node.Labels).To(HaveKeyWithValue(karpv1.CapacityTypeLabelKey, karpv1.CapacityTypeOnDemand)) | ||
| Expect(node.Labels).ToNot(HaveKey(corecloudprovider.ReservationIDLabel)) | ||
| }) | ||
| It("should ignore nodeclaims which aren't registered", func() { | ||
| out := awsEnv.EC2API.DescribeInstancesBehavior.Output.Clone() | ||
| out.Reservations[0].Instances[0].CapacityReservationId = nil | ||
| awsEnv.EC2API.DescribeInstancesBehavior.Output.Set(out) | ||
| delete(nodeClaim.Labels, karpv1.NodeRegisteredLabelKey) | ||
|
|
||
| ExpectApplied(ctx, env.Client, nodeClaim) | ||
| ExpectSingletonReconciled(ctx, controller) | ||
| nodeClaim = ExpectExists(ctx, env.Client, nodeClaim) | ||
| Expect(nodeClaim.Labels).To(HaveKeyWithValue(karpv1.CapacityTypeLabelKey, karpv1.CapacityTypeReserved)) | ||
| Expect(nodeClaim.Labels).To(HaveKeyWithValue(corecloudprovider.ReservationIDLabel, reservationID)) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.