-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@internal API elements are erased for all languages except TypeScript #1947
Labels
bug
This issue is a bug.
effort/large
Large work item – several weeks of effort
language/typescript
Related to Typescript code
p1
Comments
mergify bot
pushed a commit
that referenced
this issue
Oct 23, 2020
…wnstream (#2172) Stop setting `stipInternal: true` in `tsconfig.json` files, as this makes it impossible to mark intentionally unexported types as `@internal` without causing downstream compilation failures due to missing type declarations. Fixes #1947 Related to #1830 --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
|
nija-at
pushed a commit
to aws/aws-cdk
that referenced
this issue
Oct 29, 2020
This reverts commit 65be3a0. Original PR: #10531 Co-authored-by: Ayush Goyal <goyalayu@amazon.com> This commit was previously reverted due to a bug in jsii - aws/jsii#1947 and aws/jsii#1830. This has been fixed in jsii version 1.14.0.
mergify bot
pushed a commit
to aws/aws-cdk
that referenced
this issue
Oct 30, 2020
This reverts commit 65be3a0. Original PR: #10531 Co-authored-by: Ayush Goyal <goyalayu@amazon.com> relates #10119 This commit was previously reverted due to a bug in jsii - aws/jsii#1947 and aws/jsii#1830. This has been fixed in jsii version 1.14.0. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb
pushed a commit
to cdklabs/decdk
that referenced
this issue
Jan 18, 2022
This reverts commit 4641fd47a464ea20f5536c0d58cfb8f24f9698fe. Original PR: #10531 Co-authored-by: Ayush Goyal <goyalayu@amazon.com> relates #10119 This commit was previously reverted due to a bug in jsii - aws/jsii#1947 and aws/jsii#1830. This has been fixed in jsii version 1.14.0. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue is a bug.
effort/large
Large work item – several weeks of effort
language/typescript
Related to Typescript code
p1
🐛 Bug Report
Affected Languages
TypeScript
orJavascript
Python
Java
C#
,F#
, ...)What is the problem?
Currently in
compliance.ts
:We made this work (with lots of effort) for jsii client languages... but then forget to do it for TypeScript. The
.d.ts
looks like this:This leads to compilation errors for TypeScript.
The text was updated successfully, but these errors were encountered: