Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert s3 bucket ownership enforce rule #159

Merged

Conversation

bhallasaksham
Copy link
Contributor

@bhallasaksham bhallasaksham commented Jan 14, 2025

Description of changes:

This reverts PR #122 as the change breaks backwards compatibility.

Testing done:

Created a new RPM and tested with SQL test using the ECS setup

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bhallasaksham bhallasaksham marked this pull request as draft January 14, 2025 23:50
@bhallasaksham bhallasaksham force-pushed the revert-s3-bucket-ownership-enforce-rule branch 2 times, most recently from 93f7502 to 681bf92 Compare January 15, 2025 01:00
@bhallasaksham bhallasaksham marked this pull request as ready for review January 15, 2025 01:02
@bhallasaksham bhallasaksham merged commit b48a386 into aws:dev Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants