Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update logs with dir paths #145

Conversation

muskanlalit18
Copy link
Contributor

Issue #, if available:

Description of changes:

  1. Uncommented cred file path
  2. Logged all directory paths to the logger file

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  1. Verified that the paths are logged to the console and to the logger file.
Credentials-fetcher daemon has started running
on request failures check logs located at /var/credentials-fetcher/logging
krb_files_dir = /var/credentials-fetcher/krbdir
cred_file =  (lease id: )
logging_dir = /var/credentials-fetcher/logging
unix_socket_dir = /var/credentials-fetcher/socket
Thread 0: top of stack near 0x7f813b1ffbe0; argv_string=grpc_thread
Thread 0: top of stack near 0x7f813a57fb28; argv_string=krb_ticket_refresh_thread
2024-11-20 23:11:57     INFO: Server listening on unix:/var/credentials-fetcher/socket/credentials_fetcher.sock
2024-11-20 23:11:57     INFO: CallDataCreateKerberosLease 0x7f813400d770status: 0
2024-11-20 23:11:57     INFO: AddNonDomainJoinedKerberosLease 0x7f813400e1a0status: 0
2024-11-20 23:11:57     INFO: RenewNonDomainJoinedKerberosLease 0x7f813400ebe0status: 0
2024-11-20 23:11:57     INFO: CallDataDeleteKerberosLease 0x7f813400f600status: 0
2024-11-20 23:11:57     INFO: CallDataHealthCheck 0x7f8134010090 status: 0
2024-11-20 23:21:57     INFO: renewal started

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@muskanlalit18 muskanlalit18 merged commit c3d662c into aws:fixes_for_DNS_and_distinguishedName Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants