-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: variadic methods build errors #144
fix: variadic methods build errors #144
Conversation
0fcf4e5
to
95cea2b
Compare
} | ||
sd_journal_print( level, logFmt.c_str(), logs... ); | ||
write_log( logFmt.c_str(), logs... ); | ||
// std::string logFmt = fmt; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove line 133 and 134
@@ -219,24 +224,22 @@ int main( int argc, const char* argv[] ) | |||
cf_daemon.gmsa_account_name = CF_TEST_GMSA_ACCOUNT; | |||
|
|||
std::cerr << "krb_files_dir = " << cf_daemon.krb_files_dir << std::endl; | |||
//std::cerr << "cred_file = " << cf_daemon.cred_file << " (lease id: " << cred_file_lease_id | |||
// << ")" << std::endl; | |||
// std::cerr << "cred_file = " << cf_daemon.cred_file << " (lease id: " << cred_file_lease_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to remove @smhmhmd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The std:cerr can be added to write_log as well, also, those prints can be brought back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall I add all of these cerr logs to write_log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go ahead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two minor comments to remove commented out code, but otherwise LGTM
Issue #, if available:
Description of changes:
[Opensource Ubuntu mode]
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.