-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dockerfile typo #124
fix: Dockerfile typo #124
Conversation
Thank you for your contribution @justas05 ! We will review it and let you know if we have any questions. |
@jamolina, can you help me build in docker?
|
Hey @justas05, please pull the latest version to get the fix that got merged today. Also, I'm curious about the last commit on this PR. Was there a reason to change the remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ubuntu 22.04 builds successfully, but I see an issue with Ubuntu 20.04. Could you check my comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience during this process. Changes look good. Thanks again for your contribution!
Issue #, if available:
Description of changes: not required
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.