Enable optional SQL query capture for PostgreSQL #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willarmiros
reviewed
Mar 30, 2021
There was a problem hiding this comment.
Sorry for the late response here. Generally looks good to me, thanks for your contribution! Could you also add a quick line of documentation here: https://github.com/aws/aws-xray-sdk-node/tree/master/packages/core#environment-variables
packages/postgres/lib/postgres_p.js
Outdated
| @@ -133,6 +133,9 @@ function createSqlData(connParams, query) { | |||
| var data = new SqlData(DATABASE_VERS, DRIVER_VERS, connParams.user, | |||
| connParams.host + ':' + connParams.port + '/' + connParams.database, | |||
| queryType); | |||
| if (process.env.ENABLE_SQL_QUERY_CAPTURE) { | |||
There was a problem hiding this comment.
Can you change this to AWS_XRAY_COLLECT_SQL_QUERIES? To be consistent with our other SDKs that have this feature
|
@tomekzar Can you address the comment? Happy to merge once it is addressed. |
|
@willarmiros Sorry for the late response; the comment applied. Thanks for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #9
Description of changes:
Add an optional possibility to capture PostgreSQL SQL query and include it in subsegment data.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.