fix: keep Query instances passed to connection.query intact #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I simply missed that case. |
haotianw465
approved these changes
Aug 13, 2019
srprash
approved these changes
Aug 16, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #136
Description of changes:
Preserves the first argument of resolveArguments when it is an Object and no callback(2nd argument) has been provided. This because in the case described in #136 (comment) it's relying on the eventEmitter that's in the Mysql.Query instance provided in the first argument.
Since resolveArguments part where the first argument is an object part was added in #62, I would like to ask @jafl whether he remembers what case (presumably in mysql2) this was added, so we can check whether that would still pass as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.