Clear trace entities from asynchronous thread. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4dcfa0c to
c476a1b
Compare
Previously a segment stayed on the worker thread when a servlet was processed asynchronously. Which means that the next user of this thread will encounter this segment. This typically results in traces like: Beginning new segment while another segment exists in the segment context.
c476a1b to
c653166
Compare
|
@steven-aerts |
chrisradek
reviewed
Feb 1, 2019
...corder-sdk-core/src/test/java/com/amazonaws/xray/javax/servlet/AWSXRayServletFilterTest.java
Show resolved
Hide resolved
Co-Authored-By: steven-aerts <steven.aerts@gmail.com>
|
@chrisradek thanks for the extra test, I think it does nicely what you suggest. Thanks, Steven |
chrisradek
approved these changes
Feb 1, 2019
There was a problem hiding this comment.
@steven-aerts
Looks good to me! Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a segment stayed on the worker thread when a servlet was processed asynchronously.
Which means that the next user of this thread will encounter this segment.
This typically results in traces like:
Beginning new segment while another segment exists in the segment context.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.