Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping grgit version #385

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Bumping grgit version #385

merged 3 commits into from
Jun 23, 2023

Conversation

atshaw43
Copy link
Contributor

@atshaw43 atshaw43 commented Jun 23, 2023

Issue #, if available:
https://github.com/aws/aws-xray-sdk-java/actions/runs/5358250724/jobs/9720271919
https://repo1.maven.org/maven2/org/ajoberstar/grgit/grgit-core/
Version 4.0.2 has been deleted from maven for grgit.

Description of changes:
Bumping grgit version to 4.1.1.
I tried version 5.2.0, but it required a minimum Java version of 11 and we compile for 1.8.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atshaw43 atshaw43 requested a review from a team as a code owner June 23, 2023 17:06
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Merging #385 (2fa480e) into master (37655e2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #385   +/-   ##
=========================================
  Coverage     28.09%   28.09%           
  Complexity      574      574           
=========================================
  Files           138      138           
  Lines          5254     5254           
  Branches        634      634           
=========================================
  Hits           1476     1476           
  Misses         3577     3577           
  Partials        201      201           

Copy link
Contributor

@wangzlei wangzlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atshaw43
Copy link
Contributor Author

https://github.com/aws/aws-xray-sdk-java/actions/runs/5358721286/jobs/9721394658
Could not find org.ajoberstar.grgit:grgit-core:4.0.2.

@atshaw43 atshaw43 merged commit f81966d into aws:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants