use jackson to snake case for better performance #382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Hello, I am big fan of making things faster and originally was trying to avoid some String.replaceAll calls in TracingHandler, but found that you already have a better StringTransform implementation but not using it there,
after looking more deeply I found that using the SnakeCaseStrategy from PropertyNamingStrategies that is already highly optimized was the best route.
Thanks.
ps. I checked the performance using this branch https://github.com/rudygt/aws-xray-sdk-java/tree/benchmark, I dont think merging that test is needed. this is the output I get on my system.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.