Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Jakarta support #372

Merged
merged 10 commits into from
Feb 21, 2023
Merged

Adding Jakarta support #372

merged 10 commits into from
Feb 21, 2023

Conversation

atshaw43
Copy link
Contributor

@atshaw43 atshaw43 commented Feb 15, 2023

Issue #, if available: #364
The new version of Spring supports Jakarta instead of Javax.

Description of changes:
Add a parallel set of classes for Jakarta for all Javax related files.

There are no business logic changes between Jakarta and Javax.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atshaw43 atshaw43 requested a review from a team as a code owner February 15, 2023 02:24
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Attention: Patch coverage is 52.11864% with 113 lines in your changes missing coverage. Please review.

Project coverage is 58.12%. Comparing base (cbf9f62) to head (2bc6cf4).
Report is 28 commits behind head on master.

Files Patch % Lines
...aws/xray/jakarta/servlet/AWSXRayServletFilter.java 52.51% 62 Missing and 23 partials ⚠️
...strategy/jakarta/DynamicSegmentNamingStrategy.java 0.00% 18 Missing ⚠️
...y/jakarta/servlet/AWSXRayServletAsyncListener.java 61.11% 6 Missing and 1 partial ⚠️
...s/xray/strategy/jakarta/SegmentNamingStrategy.java 80.00% 2 Missing ⚠️
...y/strategy/jakarta/FixedSegmentNamingStrategy.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #372      +/-   ##
============================================
- Coverage     58.41%   58.12%   -0.29%     
- Complexity     1229     1269      +40     
============================================
  Files           133      138       +5     
  Lines          5011     5247     +236     
  Branches        589      633      +44     
============================================
+ Hits           2927     3050     +123     
- Misses         1814     1902      +88     
- Partials        270      295      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atshaw43
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants