Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying Oversampling Mitigation #356

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Simplifying Oversampling Mitigation #356

merged 2 commits into from
Oct 12, 2022

Conversation

atshaw43
Copy link
Contributor

@atshaw43 atshaw43 commented Oct 5, 2022

Issue #, if available:

Description of changes:
Simplifying Oversampling Mitigation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atshaw43 atshaw43 requested a review from a team as a code owner October 5, 2022 22:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #356 (19c1c77) into master (5dce456) will decrease coverage by 0.14%.
The diff coverage is 51.42%.

@@             Coverage Diff              @@
##             master     #356      +/-   ##
============================================
- Coverage     58.54%   58.40%   -0.15%     
+ Complexity     1234     1223      -11     
============================================
  Files           133      132       -1     
  Lines          4986     4986              
  Branches        595      592       -3     
============================================
- Hits           2919     2912       -7     
- Misses         1793     1803      +10     
+ Partials        274      271       -3     
Impacted Files Coverage Δ
...va/com/amazonaws/xray/contexts/SegmentContext.java 88.23% <ø> (ø)
...a/com/amazonaws/xray/entities/DummySubsegment.java 0.00% <0.00%> (ø)
...n/java/com/amazonaws/xray/entities/Subsegment.java 100.00% <ø> (+16.66%) ⬆️
...va/com/amazonaws/xray/entities/NoOpSubSegment.java 88.50% <40.00%> (-4.68%) ⬇️
...onaws/xray/contexts/ThreadLocalSegmentContext.java 72.91% <50.00%> (-1.56%) ⬇️
.../amazonaws/xray/contexts/LambdaSegmentContext.java 76.00% <55.55%> (-0.72%) ⬇️
...va/com/amazonaws/xray/entities/SubsegmentImpl.java 72.13% <85.71%> (+0.20%) ⬆️
.../main/java/com/amazonaws/xray/AWSXRayRecorder.java 63.58% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@wangzlei wangzlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atshaw43 atshaw43 merged commit ad01b46 into aws:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants