Remove unnecessary credentials retrieval #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just overriding the signer to a no-op signer in client config still causes the default credentials provider chain to be invoked and fail in the absence of credentials obtainable by the default chain. Instead, build the client with anonymous credentials, which skips both signing and credentials retrieval.
haotianw465
approved these changes
Oct 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Just overriding the signer to a no-op signer in client config still causes the default credentials provider chain to be invoked and fail in the absence of credentials obtainable by the default chain. Instead, build the client with anonymous credentials, which skips both signing and credentials retrieval.
Local
mvn verify -Dgpg.skip=truepasses.Discussed this with @haotianw465 previously.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.