Revert from bom deps. Set duplicatesStrategy for benchmark project #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#334 introduced aws-java-sdk dependencies version to be specified using
aws-java-sdk-bom
in the dependencyManagement which would then resolve any AWS JAVA SDK dependency across all projects in the repo.The
./gradlew build
builds successfully from the root, however,./gradle jmh
(used for running benchmarks) fails to resolve dependency with the following message:Description of changes:
Partially reverting the changes in Upgrade AWS Java SDK to 1.12.228 #334 to specify version 1.12.228 for each of the aws-java-sdk dependencies and remove the declaration of aws-java-sdk-bom.
This is a temporary measure to not have a broken project and in the future we should try and find a way to define the dependency version through bom in a single place.
From Gradle 7, it is required to specify a
duplicatesStrategy
. No doing so will result in this error when running./gradlew jmh
:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.