Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert from bom deps. Set duplicatesStrategy for benchmark project #336

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

srprash
Copy link
Contributor

@srprash srprash commented Jun 2, 2022

Issue:
#334 introduced aws-java-sdk dependencies version to be specified using aws-java-sdk-bom in the dependencyManagement which would then resolve any AWS JAVA SDK dependency across all projects in the repo.
The ./gradlew build builds successfully from the root, however, ./gradle jmh (used for running benchmarks) fails to resolve dependency with the following message:

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':aws-xray-recorder-sdk-benchmark:jmhJar'.
> Could not resolve all files for configuration ':aws-xray-recorder-sdk-benchmark:jmhRuntime'.
   > Could not find com.amazonaws:aws-java-sdk-xray:.
     Required by:
         project :aws-xray-recorder-sdk-benchmark > project :aws-xray-recorder-sdk-core

Description of changes:

  • Partially reverting the changes in Upgrade AWS Java SDK to 1.12.228 #334 to specify version 1.12.228 for each of the aws-java-sdk dependencies and remove the declaration of aws-java-sdk-bom.
    This is a temporary measure to not have a broken project and in the future we should try and find a way to define the dependency version through bom in a single place.

  • From Gradle 7, it is required to specify a duplicatesStrategy. No doing so will result in this error when running ./gradlew jmh:

    > Task :aws-xray-recorder-sdk-benchmark:jmhJar FAILED
    
    FAILURE: Build failed with an exception.
    
    * What went wrong:
    Execution failed for task ':aws-xray-recorder-sdk-benchmark:jmhJar'.
    > Entry LICENSE is a duplicate but no duplicate handling strategy has been set. Please refer to 
    https://docs.gradle.org/7.4.2/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy for details.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srprash srprash changed the title Revert some deps versioning from bom. Set duplicatesStrategy for benc… Revert from bom deps. Set duplicatesStrategy for benchmark project Jun 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #336 (c5e97b7) into master (5730d71) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #336   +/-   ##
=========================================
  Coverage     58.92%   58.92%           
  Complexity     1206     1206           
=========================================
  Files           131      131           
  Lines          5066     5066           
  Branches        593      593           
=========================================
  Hits           2985     2985           
  Misses         1806     1806           
  Partials        275      275           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5730d71...c5e97b7. Read the comment docs.

@srprash srprash marked this pull request as ready for review June 2, 2022 17:29
@srprash srprash requested a review from a team as a code owner June 2, 2022 17:29
Copy link
Contributor

@NathanielRN NathanielRN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Added a few formatting suggestions.

Co-authored-by: Nathaniel Ruiz Nowell <enruizno@uwaterloo.ca>
@srprash srprash merged commit 2e22dcb into aws:master Jun 2, 2022
@srprash srprash deleted the fix_project_deps branch June 2, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants