Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PR for v2.11.1 #331

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Release PR for v2.11.1 #331

merged 2 commits into from
Apr 7, 2022

Conversation

wangzlei
Copy link
Contributor

@wangzlei wangzlei commented Apr 6, 2022

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wangzlei wangzlei requested a review from a team as a code owner April 6, 2022 03:30
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #331 (c565d4c) into master (cd3b9e7) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #331      +/-   ##
============================================
+ Coverage     58.84%   58.92%   +0.07%     
- Complexity     1205     1206       +1     
============================================
  Files           131      131              
  Lines          5066     5066              
  Branches        593      593              
============================================
+ Hits           2981     2985       +4     
+ Misses         1809     1806       -3     
+ Partials        276      275       -1     
Impacted Files Coverage Δ
...ava/com/amazonaws/xray/AWSXRayRecorderBuilder.java 69.29% <0.00%> (+0.87%) ⬆️
...va/com/amazonaws/xray/entities/SubsegmentImpl.java 76.05% <0.00%> (+4.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd3b9e7...c565d4c. Read the comment docs.

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments

CHANGELOG.md Outdated
@@ -1,5 +1,10 @@
# Change Log

## 2.11.1 - 2022-04-05
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 2.11.1 - 2022-04-05
## 2.11.1 - 2022-04-06

CHANGELOG.md Outdated
## 2.11.1 - 2022-04-05
- Update Spring dependencies to address cve-2022-22965
[PR 329](https://github.com/aws/aws-xray-sdk-java/pull/329)
- Update Spring dependencies to 5.3.18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Update Spring dependencies to 5.3.18

Seems redundant?

Copy link
Contributor

@bhautikpip bhautikpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangzlei wangzlei merged commit 2dcd09e into aws:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants