Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.gradle.kts #312

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Update build.gradle.kts #312

merged 1 commit into from
Dec 16, 2021

Conversation

lupengamzn
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Upgrade Log4J to the latest

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Upgrade Log4J to the latest
@lupengamzn lupengamzn requested a review from a team as a code owner December 10, 2021 05:28
@codecov-commenter
Copy link

Codecov Report

Merging #312 (67e4c2f) into master (f4bc1e7) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #312      +/-   ##
============================================
- Coverage     58.98%   58.86%   -0.12%     
  Complexity     1206     1206              
============================================
  Files           131      131              
  Lines          5066     5066              
  Branches        593      593              
============================================
- Hits           2988     2982       -6     
- Misses         1803     1809       +6     
  Partials        275      275              
Impacted Files Coverage Δ
...va/com/amazonaws/xray/entities/SubsegmentImpl.java 71.83% <0.00%> (-4.23%) ⬇️
.../java/com/amazonaws/xray/entities/SegmentImpl.java 87.34% <0.00%> (-3.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4bc1e7...67e4c2f. Read the comment docs.

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@@ -6,9 +6,9 @@ plugins {
dependencies {
api(project(":aws-xray-recorder-sdk-core"))

compileOnly("org.apache.logging.log4j:log4j-api:2.13.3")
compileOnly("org.apache.logging.log4j:log4j-api:2.15.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case don't know / helps - you shouldn't need to do a patch release for this since it's a compileOnly dependency

@willarmiros willarmiros merged commit 76c5a20 into aws:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants