Opt-in support to collect SQL queries. #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there support for displaying the SQL in the trace directly? Right now it's only available in SQL tab in the subsegment. |
willarmiros
reviewed
May 10, 2021
There was a problem hiding this comment.
Thanks for the contribution @stnor! Unfortunately you're only able to see the SQL query in that tab today.
aws-xray-recorder-sdk-sql/src/main/java/com/amazonaws/xray/sql/TracingStatement.java
Outdated
Show resolved
Hide resolved
…/TracingStatement.java Changing name of system property to AWS XRAY standard. Co-authored-by: William Armiros <54150514+willarmiros@users.noreply.github.com>
willarmiros
reviewed
Aug 4, 2021
There was a problem hiding this comment.
Sorry for missing the follow up on this, but code LGTM! Can you please include a blurb in the readme as well? https://github.com/aws/aws-xray-sdk-java#intercept-jdbc-based-sql-queries
|
Updated the readme, I hope it looks alright. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#28
Description of changes:
Opt-in to collect SQL via Environment or System property.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.