Added Begin segment with sampling #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2020 12:48
anuraaga
approved these changes
Aug 23, 2020
| statistics.incBorrowed(); | ||
| res.setSampled(true); | ||
|
|
||
| return res; | ||
| } | ||
|
|
||
| logger.debug("Sampling target has expired for rule " + getName() + ". Using fixed rate."); | ||
| if (logger.isDebugEnabled()) { | ||
| logger.debug(String.format("Sampling target has expired for rule %s. Using fixed rate of %d percent.", |
There was a problem hiding this comment.
Think we should stick to concatenation, it's only when debug logs are enabled but still not worth taking the String.format hit.
There was a problem hiding this comment.
Fair enough, will update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#74
Description of changes:
Added an API to begin a segment and apply the recorder's sampling strategy to it. In the future, this API will be deprecated and this will be the default behavior of
beginSegment. Tested on my sample app with centralized sampling.Also improved debug logging within the centralized sampling module, and added a fast-fail to the
endSegmentto make sure we don't emit weird logs when ending a no-op segment.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.