added lazy initialization to improve withDefaultPlugins performance #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Aug 17, 2020
|
|
||
| // lazily initialize for performance on unused plugins | ||
| if (OBJECT_MAPPER == null) { | ||
| OBJECT_MAPPER = new ObjectMapper(); |
There was a problem hiding this comment.
Since this is only called once anyways I guess there's no point in even having a static variable if we're lazying
There was a problem hiding this comment.
Ah sorry I meant we can just have local variable
ObjectMapper objectMapper = new ObectMapper();
added 2 commits
August 16, 2020 23:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#117
Description of changes:
In order to improve the time it takes to quickly construct and check
isEnabledon all plugins, I adjusted a couple other plugins to fail faster (related to #192):ElasticBeanstalkPlugin, madeObjectMapperinitialization lazyEKSPlugin, made call togetClusterNamelazyAlso reduced logging level for missing log groups to
debug, since log group discovery is not yet implemented for all plugins and we shouldn't emit a warning in that case.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.