added stacktrace to Log error strat #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Aug 7, 2020
| @@ -32,6 +32,7 @@ | |||
| @Override | |||
| public void contextMissing(String message, Class<? extends RuntimeException> exceptionClass) { | |||
| logger.error("Suppressing AWS X-Ray context missing exception (" + exceptionClass.getSimpleName() + "): " + message); | |||
| logger.debug(new RuntimeException(message)); | |||
There was a problem hiding this comment.
The exception constructor has a lot of overhead, so we need to call it only when debug is enabled
There was a problem hiding this comment.
Thanks, a bit tired :)
anuraaga
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds
debug-level logging of the stacktrace for context missing exceptions that are suppressed by the Log Error strategy. This could be helpful for both customers and us to debug CME issues, especially in the agent whose default strategy is Log Error.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.