Use 1 lock to protect entity.subsegments (#181) #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use only one type of lock to protect entity.subsegments. In the past two different locking mechanisms were used. This can cause a race condition where the subsegments list was being manipulated while being read.
anuraaga
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
Thanks a lot! This is definitely needed. I'm slightly worried that now these spots may block for a relatively long time as subsegments are streamed out, but the correctness is more important and we'll have to hope such possible blocking doesn't have a too negative impact on apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use only one type of lock to protect entity.subsegments.
In the past two different locking mechanisms were used. This can cause
a race condition where the subsegments list was being manipulated while
being read.
*Issue #181
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.