Depend on aws sdk modules from instrumentor for runtime rather than c… #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willarmiros
reviewed
Jun 11, 2020
| @@ -4,7 +4,7 @@ plugins { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compileOnly(project(":aws-xray-recorder-sdk-aws-sdk")) | |||
| implementation(project(":aws-xray-recorder-sdk-aws-sdk")) | |||
There was a problem hiding this comment.
We actually don't have a dependency on the aws-xray-recorder-sdk-aws-sdk module currently. But that should be fine since the customers who are depending on both right now would just have it deduped. We should patch the docs when this is released.
willarmiros
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ompile only.
The dependencies are needed when a user app runs too, so
compileOnly, which indicates it's only needed when this module is compiled, wasn't right and would require users to add both dependencies.Note to prevent confusion as it's happening right now, this does not affect our next release, which we're still using Maven for. It probably would affect the one after that where we should have switched to Gradle by then.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.