Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More safety in UnsignedXrayClient #154

Merged
merged 1 commit into from
May 26, 2020
Merged

More safety in UnsignedXrayClient #154

merged 1 commit into from
May 26, 2020

Conversation

anuraaga
Copy link
Contributor

  • Use older Jackson property at least while we depend on AWS SDK which defaults to an old version
  • Checking null for a nullable value (not exercised by our code in practice but noticed it elsewhere)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

willarmiros
willarmiros approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srprash srprash merged commit 450a4bb into aws:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willarmiros willarmiros willarmiros approved these changes

@shengxil shengxil Awaiting requested review from shengxil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anuraaga @willarmiros @srprash