Fixed implementation of TracingStatement when no segment is present. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves issues brought up in aws#136
shengxil
reviewed
Apr 2, 2020
aws-xray-recorder-sdk-sql/src/main/java/com/amazonaws/xray/sql/TracingStatement.java
Outdated
Show resolved
Hide resolved
* Removed the extra calls to `method.invoke(delegate, args` so all calls happen within the try/catch block. * Added a message at the end of the logging statement if the tracing was enabled or not during the execution
shengxil
reviewed
Apr 6, 2020
aws-xray-recorder-sdk-sql/src/main/java/com/amazonaws/xray/sql/TracingStatement.java
Outdated
Show resolved
Hide resolved
shengxil
suggested changes
Apr 6, 2020
shengxil
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issues brought up in #136
Adds transparent exception handling from TracingStatement when no segment is present.
Adds new tests to test for both checked and unchecked exceptions also tests the exceptions in a environment with no segment created and
IgnoreErrorContextMissingStrategyset.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.